Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable conda installation when using custom docker images #3628

Closed
hemildesai opened this issue Jun 3, 2024 · 3 comments
Closed

Comments

@hemildesai
Copy link
Contributor

When using a custom docker image as runtime environment, there should be an option to disable the CONDA_INSTALLATION_COMMANDS during setup which the user can configure.

I think setting the value to empty string here when a custom image is present should suffice.

This will also help reduce the startup time.

Let me know your thoughts if this a good idea?

@Michaelvll
Copy link
Collaborator

Thanks for raising this @hemildesai! We were installing conda for all clusters to keep environments aligned. We can consider adding a knob in ~/.sky/config.yaml to disable the conda installation for better speed.

In that case, setting CONDA_INSTALLATION_COMMANDS may not be sufficient, as we may need some checks for the default Python version on the system, and not install conda only when python=3.10 to make sure the dependency for skypilot runtime can be correctly installed.

@hemildesai
Copy link
Contributor Author

hemildesai commented Jun 3, 2024

@Michaelvll Ah ok, makes sense. I would assume it would require changes to https://github.com/skypilot-org/skypilot/blob/master/sky/skylet/constants.py#L131 as well.

But would be nice to reuse the python environment directly inside the container.

@cblmemo
Copy link
Collaborator

cblmemo commented Sep 4, 2024

This should be fixed by #3874. Closed now

@cblmemo cblmemo closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants