Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Remove fractional A10 instance types in catalog #3722

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Jul 4, 2024

Resolves (partially) #3708 by removing those fractional types

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Running the fetcher and make sure the output does not contain any fractional GPU instance types.
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cblmemo cblmemo added this to the v0.6.1 milestone Jul 4, 2024
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @cblmemo! LGTM.

sky/clouds/service_catalog/data_fetchers/fetch_azure.py Outdated Show resolved Hide resolved
@cblmemo cblmemo merged commit d6ce1ba into master Jul 4, 2024
20 checks passed
@cblmemo cblmemo deleted the fix-a10-catalog branch July 4, 2024 16:33
@WesleyYue
Copy link

How does this partially resolve #3718 ?

@cblmemo
Copy link
Collaborator Author

cblmemo commented Jul 6, 2024

How does this partially resolve #3718 ?

Hi @WesleyYue ! Thanks for the catch. Actually it should be #3708. I updated the PR and thanks for pointing it out!

Michaelvll added a commit that referenced this pull request Aug 23, 2024
* fix

* Update sky/clouds/service_catalog/data_fetchers/fetch_azure.py

Co-authored-by: Zhanghao Wu <[email protected]>

* change todo name

---------

Co-authored-by: Zhanghao Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants