Auto follow-up: cancel if already classified or has spectra #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoughlin
approved these changes
Sep 27, 2023
So it's the same test, plus I post a classification and run the filter again to verify that it does not trigger which is what we want. Just a way to test the skyportal + kowalski interaction at least locally, as we don't have SP running in the GA. We could make it point to preview, but not essential. |
Theodlz
added a commit
that referenced
this pull request
Sep 28, 2023
* BTS model v1 + extra ML features (#243) * update the BTS model * extra ML features * Auto follow-up: cancel if already classified or has spectra (#244) * dont trigger followup requests if there is already classification or spectra for a source * fix duplicate comments, test no followup when classified * Temporary: use all candidates (not just prv_candidates) to generate lightcurve (#249) While we are retrieving data in prod for the prv_candidates, make sure to post all the candidates for an object as detections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes in pair with a SkyPortal PR, where we make it possible to cancel triggering a follow-up request if a source is already classified, or already has spectra