Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup request deduplication: ignore "advanced" in payload, target_group_ids in deduplication #255

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

Theodlz
Copy link
Collaborator

@Theodlz Theodlz commented Oct 5, 2023

@Theodlz Theodlz changed the title Followup request deduplication: ignore "advanced" in payload Followup request deduplication: ignore "advanced" in payload, target_group_ids in deduplication Oct 5, 2023
@Theodlz
Copy link
Collaborator Author

Theodlz commented Oct 5, 2023

@nabeelre I added the rest of what we talked about in this PR as well if you want to take a look before tonight's deploy.

Now I'll work on the Fritz PR.

@Theodlz
Copy link
Collaborator Author

Theodlz commented Oct 5, 2023

Fritz PR is open: fritz-marshal/fritz#536

@Theodlz Theodlz requested a review from mcoughlin October 5, 2023 16:48
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabeelre
Copy link

nabeelre commented Oct 5, 2023

looks good!

@Theodlz Theodlz merged commit c30336f into skyportal:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants