Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default simulator? #51

Open
shams-ahmed opened this issue Jul 24, 2018 · 1 comment
Open

Default simulator? #51

shams-ahmed opened this issue Jul 24, 2018 · 1 comment

Comments

@shams-ahmed
Copy link

I'm new to snapshot testing, are there are recommending/guidelines to follow when testing?

I have this strange behaviour when I create images for iPhone x it passes and when I try to use another simulator it fails. from the diffs, I can see that the UI is slightly higher by about 4/5 px.

@shams-ahmed shams-ahmed reopened this Jul 24, 2018
@shams-ahmed shams-ahmed changed the title Default simulator Default simulator? Jul 24, 2018
@skyweb07
Copy link
Owner

yeah this is because of phone density, depends on the iphone you run the tests it will look for the @2x, @3x image if exported, I'm working on something to fix this and make it device agnostic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants