🐛 BUG: when using nebula as library in custom application - we cannot handle os.Exit produced by library

[valda-z]

What version of nebula are you using?

1.7.2

What operating system are you using?

Linux, macOS, Windows

Describe the Bug

We are using nebula as library in our own binaries. But because library code contains os.Exit, we cannot handle it.
In our solution we are using customized source code of nebula to handle it correctly.
Problem is with file interface.go on line 285:

nebula/interface.go

Lines 284 to 285 in b22ba6e

	// This only seems to happen when something fatal happens to the fd, so exit.
	os.Exit(2)

We are changing code in our solution to:
break;

And after break from loop library returns that connection is broken and we can start connecting again.

Logs from affected hosts

No logs needed

Config files from affected hosts

No response

[wadey]

I agree this should be fixed. I am curious how this is happening in your system, as I have never seen this os.Exit trigger in the wild myself. Do you have any details on that?

[johnmaguire]

Hi @valda-z - I just wanted to bump this ticket again and ask if you have any additional details regarding this line of code being hit? Thanks!

[valda-z]

I think that we can see it only in some very rare situations. But unfortunately we have no logs for this because in fact we are restarting our service and it is not issue for us ..
One situation observed is - when network interface are changing - from lan to wifi network card
Second - when disabling networking completely on machine.

[nbrownus]

Was able to repro using ip link delete $deviceName