False positive on DeprecatedCall for WebView constructor

[edenman]

As far as I can tell, WebView is not actually deprecated, but slack-lint is claiming that it is. Maybe something wrong with the annotation detector?

Lint found 6 errors, 0 warnings (10 errors filtered by baseline lint-baseline.xml). First failure:

/Users/edenman/workspace/doggifs/src/main/java/org/coffeetrain/doggifs/SetAvailableGifsScreenView.kt:23: Error: android.webkit.WebView.WebView is deprecated; consider using an alternative. [DeprecatedCall from slack-lint]
    val foo = WebView(context).apply {

Repro project: https://github.com/edenman/doggifs/compare/edenman/webview-deprecated?expand=1

[edenman]

Maybe it's confused because there is a different constructor that is deprecated?

@Deprecated
    public WebView(@NonNull Context context, @Nullable AttributeSet attrs, int defStyleAttr,
            boolean privateBrowsing)

[ZacSweers]

ah, thanks for the report. Maybe we're not resolving the correct constructor from the callsite

[edenman]

Also getting similar stuff in media3

Error: androidx.media3.common.MediaItem.fromUri is deprecated; consider using an alternative. [DeprecatedCall from slack-lint]
            HlsMediaSource.Factory(dataSourceFactory).createMediaSource(MediaItem.fromUri(newVariant.url))
                                                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

We're using latest on both: media3 1.3.1 and slack lint 0.7.3

[ZacSweers]

I think this is a bug in lint, we're just using their AbstractAnnotationDetector() and it's handing us these symbols. It seems it's resolving the wrong one when resolving overloads. Do you see it in Lint 8.7+?

[edenman]

We're not ready to update to agp 8.7 yet, Ladybug is too unstable. I'll try again in a couple months and report back

[ZacSweers]

You can update lint separately from agp fwiw

[ZacSweers]

Instructions for the above ^^

https://googlesamples.github.io/android-custom-lint-rules/usage/newer-lint.md.html

[kozaxinan]

I updated repro repo with new agp. https://github.com/kozaxinan/lint-investigation
the issue still exists on new agp and lint.

[ZacSweers]

Could you file an issue on the Android lint issue tracker? At this point it's not really something we can control, it appears lint is reporting the wrong overload

[kozaxinan]

I reported to Google. https://issuetracker.google.com/issues/371686443