Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax not highlighting correctly with shape as parameter #124

Open
agoodkind opened this issue Aug 12, 2021 · 1 comment
Open

Syntax not highlighting correctly with shape as parameter #124

agoodkind opened this issue Aug 12, 2021 · 1 comment
Labels

Comments

@agoodkind
Copy link

agoodkind commented Aug 12, 2021

Hey vscode-hack friends!

It looks like there is a syntax highlight bug when using shapes as a parameter in a function definition.

It seems that if you define a function with an inline shape shape(?'x'=>'a') $myshape = shape() immediately followed by a type aliased shape type mytype_t = shape(?'t' => 'k') mytype_t $myothershape = shape()

eg.

function myfunction(
int $anint,
shape(?'x'=>'a') $myshape = shape(),
mytype_t $myothershape = shape(),
): void {
...
}

edit: looks like it doesn't highlight it in github issues either!

@PranayAgarwal
Copy link
Member

PranayAgarwal commented Aug 12, 2021

edit: looks like it doesn't highlight it in github issues either!

Github uses the syntax highlighting definition from this repo 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants