ENH: Fixing Axes functionality on the Archive Viewer #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksharsarvesh
force-pushed
the
axes
branch
2 times, most recently
from
5e67c98
to
a3ead57
Compare
zdomke
reviewed
Jul 29, 2024
|
Ok so after much butchering, I have taken out all of the formula dependent things about axis handling. Now, if a curve is linked or unlinked, or hidden or shown (all of which have nothing to do with formulas), then axis handling is all done in the back |
…hann Archive Viewer side so that other baseplots could access that
YektaY
approved these changes
Aug 26, 2024
YektaY
reviewed
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #24
Requires the pydm PR to go through, but allows the user to cleanly navigate adding, removing, and hiding axes; as well as hiding/removing curves and it properly hiding their axes. Finally, it defaults new curves to the correct axes upon creation and allows for easy switching between axes.