Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Restructure Item Delegates #28

Merged
merged 6 commits into from
Aug 26, 2024
Merged

FIX: Restructure Item Delegates #28

merged 6 commits into from
Aug 26, 2024

Conversation

zdomke
Copy link
Collaborator

@zdomke zdomke commented Aug 2, 2024

Restructure ItemDelegates to make an abstract class to manage the editor_list. Added functionality to reset the editor_list on model reset.

@zdomke zdomke changed the title Restructure Item Delegates FIX: Restructure Item Delegates Aug 6, 2024
YektaY
YektaY reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Would just request that the doc stings have the parameters and returns added to them.

archive_viewer/widgets/item_delegates.py Outdated Show resolved Hide resolved
@zdomke
Copy link
Collaborator Author

zdomke commented Aug 9, 2024

Additional changes:

  1. Added abstractmethods to EditorDelegate
  2. Removed the unused delegates SliderDelegate and CheckboxDelegate
    a. This also included removing the now unused widget CenterCheckbox (deprecated in Archive Viewer Update #16)

@YektaY YektaY merged commit df0e2b0 into slaclab:main Aug 26, 2024
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YektaY YektaY YektaY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdomke @YektaY