Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Plot Config Import/Export #32

Merged
merged 7 commits into from
Sep 4, 2024
Merged

ENH: Plot Config Import/Export #32

merged 7 commits into from
Sep 4, 2024

Conversation

aksharsarvesh
Copy link
Contributor

@aksharsarvesh aksharsarvesh commented Aug 13, 2024 •
edited
Loading

Builds on #27

@YektaY YektaY requested review from zdomke and YektaY August 27, 2024 21:03
YektaY
YektaY approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@YektaY YektaY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only noted for more docstrings for one of the classes.

archive_viewer/mixins/plot_config.py Show resolved Hide resolved
@aksharsarvesh
Copy link
Contributor Author

Docstrings is a common issue of mine, apologies. Check again?

@aksharsarvesh aksharsarvesh force-pushed the exportPlot branch 2 times, most recently from 21419e2 to 8992ea3 Compare August 29, 2024 18:11
@aksharsarvesh
Merge branch 'newMain' into exportPlot
612fcbc 
Conflicts:
	archive_viewer/archive_viewer.py
@aksharsarvesh
Copy link
Contributor Author

Dude, I hate merge conflicts so much

zdomke
zdomke reviewed Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@zdomke zdomke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I just had one style suggestion for how I order my imports block

archive_viewer/mixins/plot_config.py Outdated Show resolved Hide resolved
@YektaY YektaY merged commit a0bb9de into slaclab:main Sep 4, 2024
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YektaY YektaY YektaY approved these changes

@zdomke zdomke Awaiting requested review from zdomke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aksharsarvesh @YektaY @zdomke