Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Calibration and Statistics PVs as Screen Properties #165

Open
eloiseyang opened this issue Jun 3, 2024 · 1 comment
Open

Include Calibration and Statistics PVs as Screen Properties #165

eloiseyang opened this issue Jun 3, 2024 · 1 comment

Comments

@eloiseyang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The profile monitor GUI needs to calibrate screens and broadcast computed beam statistics. It needs to read and write to several different PVs to accomplish these tasks.

Describe the solution you'd like
The screen class should include new properties that automatically read/write to the relevant PVs and throw meaningful errors if the PVs are inaccessible. The YAML files should store the relevant PVs
to simplify handling different screen types. The relevant PVs are listed below. This list is likely incomplete.

  • Image Size PV
  • ROI PVs
  • Resolution PVs
  • xmean and ymean positions
  • rms positions
@MattKing06
Copy link
Collaborator

Some of these have been handled in #127 but we were unable to find the relevant PVs for some screens. It might involve running the yaml generation script again and seeing if the meme service has updated these screens with PVs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants