Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On secureli init, install latest released version of hooks #159

Closed
gabenegron opened this issue Jun 28, 2023 · 2 comments
Closed

On secureli init, install latest released version of hooks #159

gabenegron opened this issue Jun 28, 2023 · 2 comments
Assignees
@RobMRodriguez
Labels
story New feature or request

Comments

@gabenegron
Copy link
Contributor

gabenegron commented Jun 28, 2023 •
edited
Loading

User Story
As a developer, when I initialize a git repo using secureli, the version of the hooks installed should be the latest released version, so I can start my development effort using the latest and greatest hooks.

Acceptance Criteria

  • When running secureli init for the first time on a repo or running secureli init --reset
    • The latest released version for each hook should be installed (i.e. latest released version of detect-secrets, black, etc)
    • The behavior is the same as what happens when the user runs secureli update --latest
  • When running secureli init on a repo that has already has a .pre-commit-config.yaml configuration file
    • No changes are made to hooks

Technical Notes

  • Current behavior is that secureli init installs hooks with specific versions associated with each hook (static config in our own repo)
  • secureli update --latest just calls pre-commit to update the hooks configured
@gabenegron gabenegron converted this from a draft issue Jun 28, 2023
@gabenegron gabenegron added the story New feature or request label Jun 28, 2023
@gabenegron gabenegron changed the title Update versions of default linters On secureli init, install latest released version of hooks Jul 5, 2023
@gabenegron gabenegron changed the title On secureli init, install latest released version of hooks On init, install latest released version of hooks Jul 5, 2023
@gabenegron gabenegron changed the title On init, install latest released version of hooks On secureli init, install latest released version of hooks Jul 6, 2023
@calebtonn calebtonn moved this from Todo to In Progress in seCureLI Aug 5, 2023
@calebtonn
Copy link
Contributor

Let's refine this story further

@gabenegron gabenegron moved this from In Progress to Todo in seCureLI Aug 10, 2023
@gabenegron gabenegron moved this from Todo to In Progress in seCureLI Sep 6, 2023
@MaxAtSlalom MaxAtSlalom self-assigned this Sep 6, 2023
@gabenegron gabenegron moved this from In Progress to Todo in seCureLI Oct 6, 2023
@RobMRodriguez RobMRodriguez moved this from Todo to In Progress in seCureLI Oct 10, 2023
@RobMRodriguez RobMRodriguez self-assigned this Oct 10, 2023
This was referenced Oct 12, 2023
Closed
Merged
calebtonn pushed a commit that referenced this issue Nov 2, 2023
@RobMRodriguez
chore: Issue 159 - Using latest git hooks (#322)
4b77d27 
#159

[Pre-commit does not support using a latest
tag](https://pre-commit.com/#using-the-latest-version-for-a-repository),
the only way to use latest is to update after install.

I tested these changes by updating the version I installed with brew
re-initializing a test repo with javascript and python code. It looks
like the fix I made to the update command could use a regression test,
that line of code cannot run without a folder path argument.

Co-authored-by: Rob Rodriguez <[email protected]>
@kevin-orlando
Copy link
Contributor

Closing. This was resolved from #322

@github-project-automation github-project-automation bot moved this from In Progress to Done in seCureLI Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobMRodriguez RobMRodriguez

Labels
story New feature or request
Projects
seCureLI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@RobMRodriguez @calebtonn @kevin-orlando @MaxAtSlalom @gabenegron