Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change language detection on commit to only run against committed code #436

Open
JordoHeffernan opened this issue Feb 13, 2024 · 0 comments
Open

Change language detection on commit to only run against committed code #436

JordoHeffernan opened this issue Feb 13, 2024 · 0 comments
Assignees
@kevin-orlando
Labels
story New feature or request

Comments

@JordoHeffernan
Copy link
Contributor

As a secureli user I don't want language detection to run agains my entire codebase on every commit

AC

  1. After the initial scan, language detection to find potential new hooks to install/run should only run against committed files
@JordoHeffernan JordoHeffernan added the story New feature or request label Feb 13, 2024
@JordoHeffernan JordoHeffernan moved this to Todo in seCureLI Feb 13, 2024
@JordoHeffernan JordoHeffernan changed the title Change language detection action to only run against committed code Change language detection on commit to only run against committed code Feb 13, 2024
@kevin-orlando kevin-orlando self-assigned this Mar 2, 2024
@kevin-orlando kevin-orlando moved this from Todo to In Progress in seCureLI Mar 2, 2024
@kevin-orlando kevin-orlando mentioned this issue Mar 19, 2024
Merged
8 tasks
JordoHeffernan added a commit that referenced this issue Mar 22, 2024
@kevin-orlando @JordoHeffernan
Feature/secureli 436 language detection (#481)
fbd983d 
secureli-436

<!-- Include general description here -->
closes #436 

Adds focused language detection during scan for specified or committed
files


## Changes
<!-- A detailed list of changes -->
* Limiting language detection to a specified set of files during scan
(unless all files is provided)
* Adding the usage of git.Repo to check the commit file diff

## Testing
<!--
Mention updated tests and any manual testing performed.
Are aspects not yet tested or not easily testable?
Feel free to include screenshots if appropriate.
 -->
* Verify that language detection can be run on either specified or
committed files during scan

## Clean Code Checklist
<!-- This is here to support you. Some/most checkboxes may not apply to
your change -->
- [x] Meets acceptance criteria for issue
- [x] New logic is covered with automated tests
- [x] Appropriate exception handling added
- [x] Thoughtful logging included
- [x] Documentation is updated
- [x] Follow-up work is documented in TODOs
- [x] TODOs have a ticket associated with them
- [x] No commented-out code included


<!--
Github-flavored markdown reference:
https://docs.github.com/en/get-started/writing-on-github
-->

---------

Co-authored-by: Jordan Heffernan <[email protected]>
@blonienc blonienc moved this from In Progress to Done in seCureLI Mar 22, 2024
@kevin-orlando kevin-orlando mentioned this issue Mar 22, 2024
Merged
8 tasks
@JordoHeffernan JordoHeffernan mentioned this issue Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-orlando kevin-orlando

Labels
story New feature or request
Projects
seCureLI
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JordoHeffernan @kevin-orlando