-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all model class items from ACTION files to shared/models.py #440
Labels
Refactor
Code that needs revision/refactoring
Comments
JordoHeffernan
changed the title
Refactor codebase to silo functionality by language/hooks, security, and observability
Move all model class items in ACTION file to models/actions.py
Feb 13, 2024
JordoHeffernan
changed the title
Move all model class items in ACTION file to models/actions.py
Move all model class items in ACTION files to models/actions.py
Feb 13, 2024
JordoHeffernan
changed the title
Move all model class items in ACTION files to models/actions.py
Move all model class items from ACTION files to shared/models.py
Feb 20, 2024
8 tasks
8 tasks
kevin-orlando
added a commit
that referenced
this issue
Mar 7, 2024
secureli-440 secureli-441 <!-- Include general description here --> closes #440 #441 Moves commonly used action and service models into shared models folder ## Changes <!-- A detailed list of changes --> * Move action models * Move service models * Remove unused action+service models ## Testing <!-- Mention updated tests and any manual testing performed. Are aspects not yet tested or not easily testable? Feel free to include screenshots if appropriate. --> * ## Clean Code Checklist <!-- This is here to support you. Some/most checkboxes may not apply to your change --> - [ ] Meets acceptance criteria for issue - [ ] New logic is covered with automated tests - [ ] Appropriate exception handling added - [ ] Thoughtful logging included - [ ] Documentation is updated - [ ] Follow-up work is documented in TODOs - [ ] TODOs have a ticket associated with them - [ ] No commented-out code included <!-- Github-flavored markdown reference: https://docs.github.com/en/get-started/writing-on-github --> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Isaac Heist <[email protected]> Co-authored-by: Jordan Heffernan <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Kathleen Hogan <[email protected]> Co-authored-by: Kathleen Hogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a secureli contributor, I want shared models to be located in a central location
AC
a. models that are only used in the file in which they're defined should be left as is.
Notes
refactor/secureli-000-modular-refactor
The text was updated successfully, but these errors were encountered: