You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a secureli contributor, I want shared models to be located in a central location
AC
create a new file called models.py in the shared directory (create it if it does not yet exist)
Move any model classes that exist at the top of files in the Services directory to the new file IF they are reused in multiple files (depending on order of operations, these files may now live in their respective modules)
a. models that are only used in the file in which they're defined should be left as is.
Move existing code that are in one off files in the models directory to shared/models.py
a. delete models directory after this is done.
Update any and all dependent imports (VS code should do this for you)
Notes
working branch to split off of: refactor/secureli-000-modular-refactor
The text was updated successfully, but these errors were encountered:
JordoHeffernan
changed the title
Move all model class items in SERVICE file to models/services.py
Move all model class items in SERVICE files to models/services.py
Feb 13, 2024
JordoHeffernan
changed the title
Move all model class items in SERVICE files to models/services.py
Move all model class items from SERVICE files to shared/models.py
Feb 20, 2024
secureli-440
secureli-441
<!-- Include general description here -->
closes#440#441
Moves commonly used action and service models into shared models folder
## Changes
<!-- A detailed list of changes -->
* Move action models
* Move service models
* Remove unused action+service models
## Testing
<!--
Mention updated tests and any manual testing performed.
Are aspects not yet tested or not easily testable?
Feel free to include screenshots if appropriate.
-->
*
## Clean Code Checklist
<!-- This is here to support you. Some/most checkboxes may not apply to
your change -->
- [ ] Meets acceptance criteria for issue
- [ ] New logic is covered with automated tests
- [ ] Appropriate exception handling added
- [ ] Thoughtful logging included
- [ ] Documentation is updated
- [ ] Follow-up work is documented in TODOs
- [ ] TODOs have a ticket associated with them
- [ ] No commented-out code included
<!--
Github-flavored markdown reference:
https://docs.github.com/en/get-started/writing-on-github
-->
---------
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isaac Heist <[email protected]>
Co-authored-by: Jordan Heffernan <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Kathleen Hogan <[email protected]>
Co-authored-by: Kathleen Hogan <[email protected]>
As a secureli contributor, I want shared models to be located in a central location
AC
a. models that are only used in the file in which they're defined should be left as is.
a. delete models directory after this is done.
Notes
refactor/secureli-000-modular-refactor
The text was updated successfully, but these errors were encountered: