Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move shared service model items to shared folder #469

Closed
wants to merge 3 commits into from
Closed

chore: Move shared service model items to shared folder #469

wants to merge 3 commits into from

Conversation

kevin-orlando
Copy link
Contributor

secureli-441

closes #441

Changes

  • Moves shared service models into shared folder
  • Removes unused models

Testing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@kevin-orlando kevin-orlando changed the title Feature/secureli 441 move service shared models chore: Move shared service model items to shared folder Feb 28, 2024
@kevin-orlando kevin-orlando changed the base branch from feature/secureli-440-move-action-shared-items to main March 1, 2024 22:12
@kevin-orlando kevin-orlando deleted the feature/secureli-441-move-service-shared-models branch March 1, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordoHeffernan JordoHeffernan JordoHeffernan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move all model class items from SERVICE files to shared/models.py
2 participants
@kevin-orlando @JordoHeffernan