Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Files Being Overwritten #570

Open
blonienc opened this issue Jun 17, 2024 · 0 comments
Open

Config Files Being Overwritten #570

blonienc opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
bug Something isn't working python Pull requests that update Python code Refactor Code that needs revision/refactoring

Comments

@blonienc
Copy link

blonienc commented Jun 17, 2024

Problem: Precommit config file is overwritten in certain circumstances when running secureli init

To reproduce

  1. Make a new git repo with a JS file
  2. Run secureli init
  3. Modify .secureli/.pre-commit-config.yaml
  4. Commit .secureli/.pre-commit-config.yaml
  5. Check out repo into a new directory
  6. Run secureli init
  7. .secureli/.pre-commit-config.yaml has now been reset back to the default value

The solution I came up with is to add a new flag for init which prevents overwriting of the precommit config: secureli init --preserve-precommit-config

@blonienc blonienc converted this from a draft issue Jun 17, 2024
@blonienc blonienc added bug Something isn't working story New feature or request python Pull requests that update Python code Refactor Code that needs revision/refactoring and removed story New feature or request labels Jun 17, 2024
@blonienc blonienc moved this from PR Review to Done in seCureLI Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code Refactor Code that needs revision/refactoring
Projects
Status: Done
Development

No branches or pull requests

2 participants