Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Labels when pushing descriptions to superset #40

Open
aibunny opened this issue Feb 8, 2024 · 8 comments
Open

Include Labels when pushing descriptions to superset #40

aibunny opened this issue Feb 8, 2024 · 8 comments

Comments

@aibunny
Copy link

aibunny commented Feb 8, 2024

I have noticed that only column descriptions are pushed to superset, I think it would be great if also Labels were included.

@one-data-cookie
Copy link
Collaborator

Thanks for the idea, @aibunny!

How would you imagine to store these in dbt YAML files so that they could be transferred to Superset? The only thing that comes to mind is under meta.label, or?

@aibunny
Copy link
Author

aibunny commented Feb 8, 2024

My initial thoughts was to have them like below but also in the meta.label would still work.

models:
  - name: Blah blah
    description: blah data mart
  columns:
      - name: column1
      description: column1 desc
      label: Column 1

@one-data-cookie
Copy link
Collaborator

Well, that wouldn't throw you an error but it wouldn't show up in dbt Docs. Only meta.label does.

columns:
  - name: account_uuid
    description: '{{ doc("account_uuid") }}'
    label: "this-is-very-interesting"
    meta:
      label: "this-is-even-more-interesting"
      dog: "cat"
image

As you can see though, the issue is that you can put literally anything into meta so this is not really a standardised thing and I'm not sure whether anyone actually uses it like this.

@aibunny
Copy link
Author

aibunny commented Feb 8, 2024

If it works let's have it

@one-data-cookie
Copy link
Collaborator

@aibunny Would you consider contributing? Alternatively, I can put this to my backlog and try adding it later on.

@aibunny
Copy link
Author

aibunny commented Feb 9, 2024

sure

@aibunny
Copy link
Author

aibunny commented Feb 10, 2024

I have done it, how should I contribute

@one-data-cookie
Copy link
Collaborator

Nice! This article should help I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants