Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you considered creating 'totalQuery' as a recording rule as well? #526

Open
mimitantono opened this issue Oct 13, 2023 · 0 comments
Open

Comments

@mimitantono
Copy link

Sloth generates recording rules like slo:sli_error:ratio_rate5m, but when considering only the error ratio, we lack important context. For a service that experiences varying request rates, a 50% error ratio over a 5-minute period could signify errors in just 2 out of 4 requests, a stark contrast to a scenario where thousands of requests occurred in another 5-minute interval.

We can enhance accuracy by including the total query in the recording rule. This enables more precise calculations when someone needs to reapply the ratio rate to different time windows, eliminating concerns about inaccuracies in averaging the averages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant