Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v0.3 #34

Open
olegklimov opened this issue Feb 15, 2024 · 44 comments · May be fixed by #37
Open

Version v0.3 #34

olegklimov opened this issue Feb 15, 2024 · 44 comments · May be fixed by #37
Assignees

Comments

@olegklimov
Copy link
Contributor

#8
#33
#32
#31
#30
#29
#28
#24
#20

@olegklimov
Copy link
Contributor Author

/bounty 1000

Copy link

algora-pbc bot commented Feb 21, 2024

💎 $1,000 bounty • Refact.ai

Steps to solve:

  1. Start working: Comment /attempt #34 with your implementation plan
  2. Submit work: Create a pull request including /claim #34 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to smallcloudai/refact-vs-classic!

Add a bountyShare on socials

@oliverqx
Copy link

oliverqx commented Feb 21, 2024

/attempt #34

Algora profile Completed bounties Tech Active attempts Options
@oliverqx 4 bounties from 3 projects
TypeScript, Python
Cancel attempt

Copy link

algora-pbc bot commented Feb 21, 2024

@oliverqx: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@oliverqx
Copy link

@olegklimov can I get assigned?

@digital-phoenix
Copy link
Contributor

digital-phoenix commented Feb 21, 2024

/attempt #34

Algora profile Completed bounties Tech Active attempts Options
@digital-phoenix    4 smallcloudai bounties
+ 2 bounties from 2 projects
Rust, C#,
Python
Cancel attempt

Copy link

algora-pbc bot commented Feb 21, 2024

@digital-phoenix: The Refact.ai team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

@gechdejenb
Copy link

can I get assigned for the issue?

@digital-phoenix
Copy link
Contributor

@olegklimov I'd be fine with @gechdejenb taking over this issue. I have enough other stuff to work on.

@Muhammad-Musab
Copy link

can i get assigned for this issue?

@digital-phoenix digital-phoenix removed their assignment Mar 18, 2024
@olegklimov
Copy link
Contributor Author

oh yeah sure why not

@itsxdamdam
Copy link

/attempt #34

Copy link

algora-pbc bot commented Mar 26, 2024

@itsxdamdam: Another person is already attempting this issue. Please don't start working on this issue unless you were explicitly asked to do so.

@korayaltq
Copy link

@Muhammad-Musab Are you still working for the issue? If not, I would love to work.

@RafaelJohn9
Copy link

Hello, here, requesting to be assigned this issue

@Ahmadkhan02
Copy link

I was trying to set this up, but how am I supposed to run the workflow for 'refact-lsp.exe' (it asks for admin rights)

@olegklimov
Copy link
Contributor Author

hi @Ahmadkhan02
It doesn't require any special rights, works on my Windows box just fine without asking anything. Maybe it asks to open a TCP port, but then it's 127.0.0.1 so it's not even a port visible from outside 🤷

@varsubham
Copy link

/attempt #34

Copy link

algora-pbc bot commented May 2, 2024

@varsubham: Another person is already attempting this issue. Please don't start working on this issue unless you were explicitly asked to do so.

@amiransari001
Copy link

Hello,

Not sure if Muhammad-Musab is still working on this issue. If so, you can ignore this. If not, I would love to be assigned.

I don’t have any experience with open source contributions or with VS Code extension development, but I have quite a bit of experience in Python, JavaScript, and working with open source projects. I also learn quickly and have a broad, deep, and solid foundation of knowledge, not to mention a bunch of time on my hands.

Appreciate your time.

@Ahmadkhan02
Copy link

hi @Ahmadkhan02 It doesn't require any special rights, works on my Windows box just fine without asking anything. Maybe it asks to open a TCP port, but then it's 127.0.0.1 so it's not even a port visible from outside 🤷

had to delete refact-lsp.exe once, somehow ended up with a corrupt file earlier

@Ahmadkhan02
Copy link

/attempt #34

Copy link

algora-pbc bot commented May 5, 2024

@Ahmadkhan02: Another person is already attempting this issue. Please don't start working on this issue unless you were explicitly asked to do so.

@Ahmadkhan02
Copy link

Ahmadkhan02 commented May 12, 2024

no, I am still facing issues with refact-lsp.exe. After git clone. it shows up like

Screenshot 2024-05-13 022156

Also when running workflow from github cli:

Screenshot 2024-05-13 022236

@toitek
Copy link

toitek commented May 13, 2024

/attempt #34

Copy link

algora-pbc bot commented May 13, 2024

@toitek: Another person is already attempting this issue. Please don't start working on this issue unless you were explicitly asked to do so.

@Ahmadkhan02
Copy link

no, I am still facing issues with refact-lsp.exe. After git clone. it shows up like

Screenshot 2024-05-13 022156

Also when running workflow from github cli:

Screenshot 2024-05-13 022236

@olegklimov @digital-phoenix any help on this? Would like to work on this issue but this is a major blocker

@thekumbhaj
Copy link

/attempt #34

Copy link

algora-pbc bot commented May 29, 2024

@thekumbhaj: Another person is already attempting this issue. Please don't start working on this issue unless you were explicitly asked to do so.

@d80ep08th
Copy link

@olegklimov , bro @Muhammad-Musab aint produced any work, @digital-phoenix removed the assignment in March. Seems like the issue is up for grabs, no ?

@Ahmadkhan02
Copy link

hi @Ahmadkhan02 It doesn't require any special rights, works on my Windows box just fine without asking anything. Maybe it asks to open a TCP port, but then it's 127.0.0.1 so it's not even a port visible from outside 🤷

Got it working. Had to build the refact-lsp code separately. Working on the issues now

@mariomerida15
Copy link

@olegklimov can i get assigned?

And what i need to do

@Ahmadkhan02
Copy link

I have made some progress on the issues but cant get the app to work. I have tracked to issue down to AddFile in RefactLanguageClient.cs. Adding some debug:
`public async Task AddFile(String filePath, String text)
{

Debug.WriteLine( $"Adding file {filePath} to LSP");

//wait for the rpc 
while (this.Rpc == null) await Task.Delay(1);

//dont send the file to the lsp if the lsp already knows about it
if (ContainsFile(filePath))
{
    return;
}

//message to send to lsp
var openParam = new DidOpenTextDocumentParams
{
    TextDocument = new TextDocumentItem
    {
        Uri = new Uri(filePath),
        LanguageId = filePath.Substring(filePath.LastIndexOf(".") + 1),
        Version = 0,
        Text = text
    }
};

//send message to lsp catch any communication errors
try
{;
    await Rpc.NotifyWithParameterObjectAsync("textDocument/didOpen", openParam);
    //add file to known file set
    files.Add(filePath);

    Debug.WriteLine($"File '{filePath}' added successfully");

}
catch (Exception e)
{
    Debug.WriteLine("Exception: " + e.Message);
    ShowStatusBarError("Server Exception: \n" + e.Message);
}

}`

i get error as:
Adding file file:///C:/Users/kahma/AppData/Local/Temp/0u5gqz5n..js to LSP
19:01:57:732 Exception thrown: 'System.ObjectDisposedException' in mscorlib.dll
19:01:57:732 Exception: Cannot access a disposed object.

how do you guys get it running?

NOTE: I have the refact-lsp.exe now. Had to build it seprate.

@olegklimov @digital-phoenix

@Ahmadkhan02
Copy link

@olegklimov anything for the above?

@olegklimov
Copy link
Contributor Author

This issue is still valid!

@Ahmadkhan02 are you working on this?

@Ahmadkhan02
Copy link

Yup @olegklimov, still working on this. Actually I am mostly done with the changes but as I stated above, I just can’t get the extension to run and hence can’t test

Even a new clone doesn’t run

@rogueloop
Copy link

hey, @Ahmadkhan02 let's collab if you are ready.

@reymondzzzz
Copy link
Member

reymondzzzz commented Jul 12, 2024

@Ahmadkhan02 I'm here to help you. What the problem with extension do u have? we have backend binary with lsp https://github.com/smallcloudai/refact-lsp. Build this one and put it in resources. Where can I find your code and test it by myself?

@Ahmadkhan02 Ahmadkhan02 linked a pull request Jul 12, 2024 that will close this issue
Copy link

algora-pbc bot commented Jul 12, 2024

💡 @Ahmadkhan02 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@Ahmadkhan02
Copy link

Hi @reymondzzzz

Screenshot 2024-07-12 215508

I have already built and added refact-lsp as shown. Thats not the issue. I am starting to think my OS is the issue here. What OS do you guys use? I can see visual studio 2022 for mac is also a thing. I can get a mac to try if thats what you guys use

@reymondzzzz
Copy link
Member

We use vsclassic on windows only. Microsoft doesn't no longer support mac version of VS

@Ahmadkhan02
Copy link

picking up this issue again after some time. Any idea when this issue comes up?

Screenshot 2024-08-26 021348

@itsxdamdam
Copy link

itsxdamdam commented Aug 26, 2024

/attempt #34

@vishalpatil1899
Copy link

/attempt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.