Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we optimize SmallRyeHealthReporter initialization a bit? #562

Open
gsmet opened this issue Aug 28, 2024 · 0 comments
Open

Should we optimize SmallRyeHealthReporter initialization a bit? #562

gsmet opened this issue Aug 28, 2024 · 0 comments

Comments

@gsmet
Copy link

gsmet commented Aug 28, 2024

It's less pressing since you made the JsonProvider static but given the SmallRyeHealthReporter bean is @ApplicationScoped, the no-arg constructor is called twice when it is initialized.

I was wondering if:

  • we could make it @Singleton but we would need to check if doesn't break any use case - not sure how easy it would be
  • move the initialization that is in the constructor to the already existing @Postconstuct.

The latter would probably be the less risky move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant