Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakarta REST Client Span Attributes #315

Open
fabrii opened this issue Jun 4, 2024 · 2 comments
Open

Jakarta REST Client Span Attributes #315

fabrii opened this issue Jun 4, 2024 · 2 comments

Comments

@fabrii
Copy link

fabrii commented Jun 4, 2024

Hello!

Is there a reason for not adding the http.route attribute to client spans name? I see it is not defined in the specification.

In the implementation I see a "TODO" in this line.

Thank you

EDIT:

Just saw that there is an url.template attribute for client name here but is not implemented.

@radcortez
Copy link
Member

Hi!

Because we are still in version 1.21: https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/http/http-spans.md#name:

HTTP client spans have no http.route attribute since client-side instrumentation is not generally aware of the "route", and therefore HTTP client spans SHOULD use {http.request.method}

Unfortunately, the spec keeps changing definitions in every version, which makes it hard to keep up. We need to upgrade soon.

@radcortez
Copy link
Member

This requires Semantic Conventions 1.26 or higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants