Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Tries to inject Vertx instance from CDI using a qualifier #2771

Closed
gaol opened this issue Sep 27, 2024 · 2 comments · Fixed by #2772
Closed

[Enhancement] Tries to inject Vertx instance from CDI using a qualifier #2771

gaol opened this issue Sep 27, 2024 · 2 comments · Fixed by #2772

Comments

@gaol
Copy link
Contributor

gaol commented Sep 27, 2024

Currently the Vertx instance used in the reactive messaging comes from either CDI Instance<Vertx> or a new instance via Vertx.vertx().

In some case, the Vertx instance is exposed with a CDI qualifier, it would be good if we can only inject the instance with the qualifier.

More information can be found at the Zulip discussion: https://wildfly.zulipchat.com/#narrow/stream/174184-wildfly-developers/topic/vertx.20subsystem.20integration

@gaol
Copy link
Contributor Author

gaol commented Sep 27, 2024

@kabir would you please check ? thanks :)

@kabir
Copy link
Contributor

kabir commented Sep 27, 2024

@ozangunalp Just so you know, we are doing this due to #2725.

At the moment in WildFly, we end up calling Vertx.vertx() for every single deployment, and also we do the same in Otel. So we are looking at adding a vertx subsystem in order to:

  • have a shared instance
  • configure things in that shared instance, as in that linked discussion

Now, although this will probably come in to WildFly soon, it will be at a lower 'stability level' so it isn't available yet in the default installation when you start WildFly normally (we're doing this to allow community to evolve faster than what we fork to become the product). The qualifier will help us opt in and out of this shared instance per subsystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants