From 8bec1a7b3cfc5c8c28625d04a2536e6fa9bc4eff Mon Sep 17 00:00:00 2001 From: Fabien Bourigault Date: Wed, 14 Nov 2018 14:35:30 +0100 Subject: [PATCH 1/3] run tests against PHP 7.3 --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index decc07fe..15574421 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,11 +8,13 @@ php: - 7.0 - 7.1 - 7.2 + - 7.3 - hhvm matrix: allow_failures: - php: hhvm + - php: 7.3 before_script: - composer self-update || true From 9e7bbab95c8613c4d4c8b8979a5ac4992fc723ef Mon Sep 17 00:00:00 2001 From: Fabien Bourigault Date: Wed, 14 Nov 2018 17:28:29 +0100 Subject: [PATCH 2/3] fix continue errors with PHP 7.3 --- src/Smalot/PdfParser/PDFObject.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Smalot/PdfParser/PDFObject.php b/src/Smalot/PdfParser/PDFObject.php index 9fd9b84a..176b22fd 100644 --- a/src/Smalot/PdfParser/PDFObject.php +++ b/src/Smalot/PdfParser/PDFObject.php @@ -326,7 +326,7 @@ public function getText(Page $page = null) // Fallback // TODO : Improve $text .= $command[self::COMMAND][0][self::COMMAND]; - continue; + break; } $sub_text = $current_font->decodeText($command[self::COMMAND]); @@ -483,7 +483,7 @@ public function getTextArray(Page $page = null) // Fallback // TODO : Improve $text[] = $command[self::COMMAND][0][self::COMMAND]; - continue; + break; } $sub_text = $current_font->decodeText($command[self::COMMAND]); From 429078cdec467ea595f19f117d37399d8a5e4143 Mon Sep 17 00:00:00 2001 From: Fabien Bourigault Date: Wed, 5 Dec 2018 15:27:13 +0100 Subject: [PATCH 3/3] PHP 7.3 is no longer allowed to fail --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 15574421..34e1293c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,7 +14,6 @@ php: matrix: allow_failures: - php: hhvm - - php: 7.3 before_script: - composer self-update || true