Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESC/motor status flags to ThrusterFeedback #9

Open
Jollerprutt opened this issue Oct 28, 2020 · 2 comments
Open

Add ESC/motor status flags to ThrusterFeedback #9

Jollerprutt opened this issue Oct 28, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jollerprutt
Copy link
Contributor

I think it would make sense to add some status flags to this message.
I.e Armed/Enabled, Running, Overheating, Too cold, Can't turn, more?

@nilsbore @NiklasRolleberg Ideas? Feedback?

std_msgs/Header header
smarc_msgs/ThrusterRPM rpm
float32 current
float32 torque

@Jollerprutt Jollerprutt added the enhancement New feature or request label Oct 28, 2020
@Jollerprutt Jollerprutt self-assigned this Oct 28, 2020
@NiklasRolleberg
Copy link
Collaborator

I like the Enabled/Disabled flag. At the moment we don't get any information about the the temperature or status of the ESC so I don't know how we could use the other flags. Perhaps we could have some kind of error code instead which we could use in the future if we find a way to get such information.

@Jollerprutt
Copy link
Contributor Author

Your ESC do have a temperature sensor mounted, so at some point we should get the temperature implemented.
But I guess the temperature and associated flags could go in a different message.
The Can't turn/propeller stuck flag could easily be monitored by a behavior tree, easier than checking last command, current rpm and that sufficient time has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants