Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using a library to provide some matrix types / logic #7

Open
mikix opened this issue Nov 14, 2023 · 0 comments
Open

Investigate using a library to provide some matrix types / logic #7

mikix opened this issue Nov 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mikix
Copy link
Contributor

mikix commented Nov 14, 2023

sklearn, for example, has built-in confusion matrix logic that might reduce some homegrown lines of code.

Maybe there's also something in sklearn or pandas that can replace some of the logic of score_matrix.

Besides logic itself, in both cases we're using raw Python data types of dicts with well-known keys. Maybe those libraries have more tightly-defined types we could pass around. Or maybe it's best to just make our own thin type wrapper to provide that tight definition.

@mikix mikix added the enhancement New feature or request label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant