Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i2b2 ProviderDimension should include constructor with PROVIDER_ID #112

Closed
comorbidity opened this issue Dec 26, 2022 · 1 comment
Closed

i2b2 ProviderDimension should include constructor with PROVIDER_ID #112

comorbidity opened this issue Dec 26, 2022 · 1 comment
Assignees
@comorbidity

Comments

@comorbidity
Copy link
Contributor

Similar to ObservationFact
https://github.com/smart-on-fhir/cumulus-etl/blob/main/cumulus/loaders/i2b2/schema.py#L257

ProviderDimension should load with PROVIDER_ID
https://github.com/smart-on-fhir/cumulus-etl/blob/main/cumulus/loaders/i2b2/schema.py#L117
@comorbidity comorbidity self-assigned this Dec 26, 2022
@comorbidity comorbidity changed the title ProviderDimension should include constructor with PROVIDER_ID i2b2 ProviderDimension should include constructor with PROVIDER_ID Dec 26, 2022
@mikix
Copy link
Contributor

mikix commented Jun 5, 2023

The constructor does load PROVIDER_ID: https://github.com/smart-on-fhir/cumulus-etl/blob/6fec41c/cumulus_etl/loaders/i2b2/schema.py#L101

We don't really use ProviderDimension at all right now, which is probably covered by #111. But the dimension class itself is ready.

@mikix mikix closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comorbidity comorbidity

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikix @comorbidity