Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: do a pass to remove noqa: S* lines #186

Open
mikix opened this issue Mar 10, 2023 · 0 comments
Open

Refactor: do a pass to remove noqa: S* lines #186

mikix opened this issue Mar 10, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mikix
Copy link
Contributor

mikix commented Mar 10, 2023

None of the current noqa: S* lines are security issues. But it's still a nicer story if there aren't any.

We have two kinds of security linter exemptions right now:

  • SQL injection (because there's no user input involved, it's just basic string formatting)
  • assert lines (because it's OK that they get ignored in optimized code, as they are just sanity checks for developers writing new tasks)

So both could be fixed easily enough (SQL maybe would use some version of bound variables and the asserts could be re-written or just dropped).

Not a high priority, but might be nice to do, to simplify the security story.

@mikix mikix added enhancement New feature or request good first issue Good for newcomers labels Jun 5, 2023
@mikix mikix changed the title Refactor: do a pass to remove nosec lines Refactor: do a pass to remove noqa: S lines Aug 2, 2024
@mikix mikix changed the title Refactor: do a pass to remove noqa: S lines Refactor: do a pass to remove noqa: S* lines Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant