Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: negative values in the algorithm charts. #17

Open
nishihatapalmer opened this issue Apr 27, 2022 · 0 comments
Open

BUG: negative values in the algorithm charts. #17

nishihatapalmer opened this issue Apr 27, 2022 · 0 comments

Comments

@nishihatapalmer
Copy link
Contributor

The results pages often pop up with a message saying there are negative values in the chart but the the baseline is zero.

Source
The negative values appear in the standard deviation 1 data, written out in output.h. It subtracts the standard deviation from the mean time. However, the standard deviation can be bigger than the mean, which results in negative values in the output.

	fprintf(fp,"var std1 = [");
	for(int il=0; il<NumPatt; il++)	if(PATT_SIZE[il]>=MINLEN && PATT_SIZE[il]<=MAXLEN) {
   		if(TIME[algo][il]==0)  fprintf(fp,",");
  		else fprintf(fp,"%.2f,",TIME[algo][il]-STD[algo][il]);
  	}
  	fprintf(fp,"];\n");

Fix
I'm not sure what the fix should be here. I can prevent negative values by having a minimum zero value here, cutting off anything
below it. I'm not sure what the right statistical approach is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant