Fan only mode and temperature (code changes) and double beep while turning on

[anthonws]

Hi!

I have a couple of Midea AC's, custom profile. All is working properly, but I noticed an error message in HA for when I was enabling fan only mode. It was complaining about target_temperature.

Looking at the code I understood that for fan_only mode it was expected to have temperature values, which I don't have in my profile. Are temperature values really affecting the operation of fan_only mode?!?

I've hacked the climate.py code a bit to not send target_temperature if operating_mode = fan_only, which works just fine, but I get now a double beep from the AC. I guess it is related to the "on" command and the "fan_only" command. Any way I can skip that?

    async def send_command(self):
        async with self._temp_lock:
            try:
                self._on_by_remote = False
                operation_mode = self._hvac_mode
                fan_mode = self._current_fan_mode
                swing_mode = self._current_swing_mode
                target_temperature = '{0:g}'.format(self._target_temperature)
                                
                _LOGGER.debug(f"Operation mode: {operation_mode}, Type: {type(operation_mode)}")
                _LOGGER.debug(f"Fan mode: {fan_mode}, Type: {type(fan_mode)}")
                _LOGGER.debug(f"Swing mode: {swing_mode}, Type: {type(swing_mode)}")
                _LOGGER.debug(f"Target temperature: {target_temperature}, Type: {type(target_temperature)}")
                #_LOGGER.debug(f"Full commands structure: {json.dumps(self._commands, indent=4)}")

                if operation_mode.lower() == HVAC_MODE_OFF:
                    await self._controller.send(self._commands['off'])
                    return

                if 'on' in self._commands:
                    await self._controller.send(self._commands['on'])
                    await asyncio.sleep(self._delay)
                
                # Handle 'fan_only' mode
                if operation_mode.lower() == 'fan_only':
                    await self._controller.send(self._commands[operation_mode][fan_mode])
                else:
                    await self._controller.send(self._commands[operation_mode][fan_mode][target_temperature])
                  
            except Exception as e:
                _LOGGER.exception(e)

[litinoveweedle]

Hello,

to my knowledge most of the HVAC devices always sent all codes together. So as in original codebase, first on, then setting mode.

Was you HVAC ON, when you tried to set fan mode? If not, do you think, that sending only fan mode code would also set your unit on?

I am just preparing PR to handle situation with any missing code more graceful. I can include changes for your case.

[litinoveweedle]

Not yet solving double beep, but this is little bit reordered your original code for fan only mode , without requirements for target temperature and with checking of the codes:

    async def send_command(self):
        async with self._temp_lock:
            try:
                self._on_by_remote = False
                operation_mode = self._hvac_mode
                fan_mode = self._current_fan_mode
                swing_mode = self._current_swing_mode
                target_temperature = '{0:g}'.format(self._target_temperature)

                if operation_mode.lower() == HVACMode.OFF:
                    if not (isinstance(self._commands, dict) and 'off' in self._commands.keys()):
                        _LOGGER.error("Missing device IR code for off operation mode.")
                        return
                    else:
                        await self._controller.send(self._commands['off'])
                    return

                if 'on' in self._commands:
                    if not (isinstance(self._commands, dict) and 'on' in self._commands.keys()):
                        _LOGGER.error("Missing device IR code for on operation mode.")
                        return
                    else:
                        await self._controller.send(self._commands['on'])
                    await asyncio.sleep(self._delay)

                if not (isinstance(self._commands, dict) and operation_mode in self._commands.keys()):
                    _LOGGER.error("Missing device IR code for %s operation mode.", operation_mode)
                    return
                elif not (isinstance(self._commands[operation_mode], dict) and fan_mode in self._commands[operation_mode].keys()):
                    _LOGGER.error("Missing device IR code for %s fan mode.", fan_mode)
                    return
                elif self._support_swing == True:
                    if not (isinstance(self._commands[operation_mode][fan_mode], dict) and swing_mode in self._commands[operation_mode][fan_mode].keys()):
                        _LOGGER.error("Missing device IR code for swing mode." + swing_mode)
                        return
                    elif operation_mode.lower() == HVACMode.FAN_ONLY:
                        await self._controller.send(
                            self._commands[operation_mode][fan_mode][swing_mode])
                    elif not (isinstance(self._commands[operation_mode][fan_mode][swing_mode], dict) and target_temperature in self._commands[operation_mode][fan_mode][swing_mode].keys()):
                        _LOGGER.error("Missing device IR code %s target temperature.", target_temperature)
                        return
                    else:
                        await self._controller.send(
                            self._commands[operation_mode][fan_mode][swing_mode][target_temperature])
                else:
                    if operation_mode.lower() == HVACMode.FAN_ONLY:
                        await self._controller.send(
                            self._commands[operation_mode][fan_mode])
                    elif not (isinstance(self._commands[operation_mode][fan_mode], dict) and target_temperature in self._commands[operation_mode][fan_mode].keys()):
                        _LOGGER.error("Missing device IR code for %s target temperature.", target_temperature)
                        return
                    else:
                        await self._controller.send(
                            self._commands[operation_mode][fan_mode][target_temperature])

            except Exception as e:
                _LOGGER.exception(e)

[anthonws]

@litinoveweedle Thanks for your time and attention. I will test this later today and will report back.

[litinoveweedle]

Ok, based on what I just learned here #PR 1200 it seems that on/off bit can be set in any IR code, and then you do not need explicitly first send HVAC on (first beep) and then set mode, fan and temperature (second beep).

This is BTW the way, how it was done in the original code SmartIR:

                if 'on' in self._commands:
                    await self._controller.send(self._commands['on'])
                    await asyncio.sleep(self._delay)

I did modified my previous example, which had anyway duplicate check there. For your test please remove dedicated 'on' code from your device codes file. Please be aware, than you have to have 'on' bit set in all other codes to make this work coherently. ;-)

I corrected and also reformatted whole code, to make it more obvious, as I missed the this intentions with 'on' command as well at first:

     async def send_command(self):
        async with self._temp_lock:
            try:
                self._on_by_remote = False
                operation_mode = self._hvac_mode
                fan_mode = self._current_fan_mode
                swing_mode = self._current_swing_mode
                target_temperature = '{0:g}'.format(self._target_temperature)

                if operation_mode.lower() == HVACMode.OFF:
                    if not (isinstance(self._commands, dict) and 'off' in self._commands.keys()):
                        _LOGGER.error("Missing device IR code for off operation mode.")
                        return
                    else:
                        await self._controller.send(self._commands['off'])
                else:
                    if not(isinstance(self._commands, dict) and 'on' in self._commands.keys()):
                        """if on code is not present, the on bit can be still set in the all operation/fan codes"""
                        pass
                    else:
                        await self._controller.send(self._commands['on'])
                        await asyncio.sleep(self._delay)

                    if not (isinstance(self._commands, dict) and operation_mode in self._commands.keys()):
                        _LOGGER.error("Missing device IR code for %s operation mode.", operation_mode)
                        return
                    elif not (isinstance(self._commands[operation_mode], dict) and fan_mode in self._commands[operation_mode].keys()):
                        _LOGGER.error("Missing device IR code for %s fan mode.", fan_mode)
                        return
                    elif self._support_swing == True:
                        if not (isinstance(self._commands[operation_mode][fan_mode], dict) and swing_mode in self._commands[operation_mode][fan_mode].keys()):
                            _LOGGER.error("Missing device IR code for swing mode." + swing_mode)
                            return
                        elif operation_mode.lower() == HVACMode.FAN_ONLY:
                            await self._controller.send(
                                self._commands[operation_mode][fan_mode][swing_mode])
                        elif not (isinstance(self._commands[operation_mode][fan_mode][swing_mode], dict) and target_temperature in self._commands[operation_mode][fan_mode][swing_mode].keys()):
                            _LOGGER.error("Missing device IR code %s target temperature.", target_temperature)
                            return
                        else:
                            await self._controller.send(
                                self._commands[operation_mode][fan_mode][swing_mode][target_temperature])
                    else:
                        if operation_mode.lower() == HVACMode.FAN_ONLY:
                            await self._controller.send(
                                self._commands[operation_mode][fan_mode])
                        elif not (isinstance(self._commands[operation_mode][fan_mode], dict) and target_temperature in self._commands[operation_mode][fan_mode].keys()):
                            _LOGGER.error("Missing device IR code for %s target temperature.", target_temperature)
                            return
                        else:
                            await self._controller.send(
                                self._commands[operation_mode][fan_mode][target_temperature])

            except Exception as e:
                _LOGGER.exception(e)

[litinoveweedle]

Hi, I merged proposed change into my fork and I will release it soon. You can test it and report back.