som: handle pruned transactions for slower updating feeds #857
+51
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalu1418
had a problem deploying
to
integration
GitHub Actions
Error
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
had a problem deploying
to
integration
GitHub Actions
Error
aalu1418
force-pushed
the
som/handle-pruned-txs
branch
from
53f0fef
to
0a0da7d
Compare
aalu1418
changed the title
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
requested review from
jmank88,
toblich,
jadepark-dev and
augustbleeds
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Sep 13, 2024
Co-authored-by: Jordan Krage <[email protected]>
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
previously approved these changes
Sep 16, 2024
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
approved these changes
Sep 16, 2024
aalu1418
temporarily deployed
to
integration
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
some solana RPC nodes will prune old transactions. if there are feeds that update slowly, transactions may be pruned from the rpc node and SOM would be unable to find a previous tx and throw an error.
that error blocks the data packed in the envelope to be used as an update. if this occurs during startup, it would cause price data to be missing until SOM sees a transaction.
this PR adds a cached value in the case that transactions are pruned. on startup with pruned transactions, it would return 0 rather than block the entire metrics update