Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn (all) tests should start/tear-down their own env and be idempotent #101

Open
krebernisak opened this issue Sep 5, 2022 · 1 comment
Open

Yarn (all) tests should start/tear-down their own env and be idempotent #101

krebernisak opened this issue Sep 5, 2022 · 1 comment

Comments

@krebernisak
Copy link
Collaborator

Currently, some project tests expect the network to be running externally before they are started, others don't have that requirement and start their own network programatically on beforeAll.

These two workflows conflict if they are ran together - no network cleanup, port conflict.

Ideally, we provide env access programmatically, so each test suite can manage their own.

Originally posted by @krebernisak in #93 (comment)
@krebernisak krebernisak changed the title Yarn workspace tests should start/tear-down their own env and be idempotent Yarn project tests should start/tear-down their own env and be idempotent Sep 5, 2022
@krebernisak krebernisak changed the title Yarn project tests should start/tear-down their own env and be idempotent Yarn (all) tests should start/tear-down their own env and be idempotent Sep 5, 2022
@krebernisak krebernisak mentioned this issue Sep 5, 2022
Merged
@ivpavici
Copy link
Contributor

ivpavici commented Nov 7, 2022

#175 is this PR related to this issue? @qperrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krebernisak @ivpavici