Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unimplemented ChainReader() method to MedianProvider #331

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Add unimplemented ChainReader() method to MedianProvider #331

merged 1 commit into from
Dec 5, 2023
+522 −1,856

Conversation

reductionista
Copy link
Contributor

Add ChainReader() method to medianProvider to satisfy the updated PluginProvider interface which we plan to commit soon to chainlink-relay:

smartcontractkit/chainlink-common#196

@reductionista reductionista mentioned this pull request Oct 18, 2023
Merged
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@reductionista reductionista merged commit ea2e3e9 into develop Dec 5, 2023
10 of 19 checks passed
@reductionista reductionista deleted the BCF-2612-ChainReader branch December 5, 2023 18:09
@reductionista reductionista mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 left review comments

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reductionista @jmank88 @ilija42