New log buffer #12357
Merged
New log buffer #12357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
ferglor
reviewed
Mar 8, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v2.go
Outdated
Show resolved
Hide resolved
- comments - renaming - new(atomic.Intxx) - sizeOfWindow(end,start)
infiloop2
reviewed
Apr 5, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/provider.go
Show resolved
Hide resolved
infiloop2
reviewed
Apr 5, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v1.go
Outdated
Show resolved
Hide resolved
infiloop2
reviewed
Apr 5, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v1.go
Show resolved
Hide resolved
infiloop2
previously approved these changes
Apr 5, 2024
ferglor
reviewed
Apr 7, 2024
core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider/buffer_v1.go
Outdated
Show resolved
Hide resolved
|
ferglor
approved these changes
Apr 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
momentmaker
added a commit
that referenced
this pull request
Apr 8, 2024
* develop: [KS-136] Write target fixes (#12743) chore/release 2.10.0 to develop (#12740) [KS-136] Disallow non-trigger steps with no dependent ref (#12742) [KS-136] Correctly handle numbers in YAML by converting them to floats or ints (#12739) New log buffer (#12357) [KS-101] Add OCR3 capability contract wrapper (#12404) core/services/relay/evm: switch RequestRound DB & Tracker to use sqlutil.DataSource (#12706) Unregister filters for old coordinator contracts contract addresses from Functions LogPollerWrapper (#12696)
momentmaker
added a commit
that referenced
this pull request
Apr 8, 2024
…ersion * develop: (32 commits) [KS-136] Write target fixes (#12743) chore/release 2.10.0 to develop (#12740) [KS-136] Disallow non-trigger steps with no dependent ref (#12742) [KS-136] Correctly handle numbers in YAML by converting them to floats or ints (#12739) New log buffer (#12357) [KS-101] Add OCR3 capability contract wrapper (#12404) core/services/relay/evm: switch RequestRound DB & Tracker to use sqlutil.DataSource (#12706) Unregister filters for old coordinator contracts contract addresses from Functions LogPollerWrapper (#12696) Add table support for capability "type" property (#12622) Backout CRIB setup on develop. (#12705) fix node upgrade test (#12702) Reduces changeset scope to `minor` for semver (#12699) rm oz dep (#12700) @chainlink.contracts release v1.0.0 (#11714) feat: contracts publishing in CI (#12102) Bump default PG conns from 20->100; enable auto-scaling open conns for mercury (#12697) chore: chainlink-github-actions/* to v2.3.10 (#12694) LOOPP plugin config validation service (#12430) [TT-924] Migrate functions load tests to Seth (#12659) Enhance automation test config (AUTO-9430) (#12689) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-8231
Description
As part of working on reliability, several mechanisms require changes so we could use scaling parameters to configure the throughput and data loss strategies of log provider and buffer.
This PR introduce log buffer v1 with improved performance, stability and control over scaling parameters.
NOTE: This is a major change to the buffer, and therefore is being done on a new struct and under a feature flag.
Changes
Testing
Existing tests are running with a flag for default version / v0 and v1.
New tests (unit) were added accordingly.