All committers have signed the CLA.

Codecov Report

Merging #31 (de2a44e) into main (d5ac5b2) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   32.13%   31.67%   -0.46%     
==========================================
  Files           5        5              
  Lines        1307     1307              
==========================================
- Hits          420      414       -6     
- Misses        827      831       +4     
- Partials       60       62       +2     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thanks for you PR. as this PR copys some manifest yamls, it is not easy to maintain two kinds of manifests(kustomize and helm). maybe use skaffold with helm deploy is a better choice, so that we can remove kustomize templates and only use helm chart. thanks again .

Sorry for my delay. I'm not familiar with skaffold, so it may takes some time for me to learn it. Please wait some moment

@weixiao-huang Don't worry, take your time. We actually talked about merging this PR first and then we make the skaffold-helm integrate ourselves. But since skaffold is really a handy tool while developing on K8s, so I'd recommend you take this as an opportunity to equip yourself with skaffold. I'm sure it will well worth your time getting familiar with skaffold, since it can really ease your dev journey on k8s :)

I finished it with skaffold

All discussions have been resolved

Is there any problem of this PR?

Hi, @weixiao-huang , sorry for the delay, there are some pending comments above need to be addressed. we need make it be compatible with skaffold too.

could you please tell me which comments? It seems all comments have been resolved

PR is stale? It would be nice to have helm chart to deploy.

there are some pending comments above need to be addressed. we need make it be compatible with skaffold too.

It seems all comments have been resolved, this MR should be reviewed by the maintainer

there are some pending comments above need to be addressed. we need make it be compatible with skaffold too.

It seems all comments have been resolved, this MR should be reviewed by the maintainer

@weixiao-huang thanks, I replied above, and plz rebase this PR, then I will review and test it again.

While waiting for this PR...
I wrote a simple chart generator script from the manifest URLs.
It helps with installing resources from plain manifests via helmfile.
Maybe this will be useful for someone who also waiting for this PR.
https://github.com/anisimovdk/chartgen

I'm thinking to generate a Helm chart by running helmify over virtink.yaml. Any thoughts? @anisimovdk @weixiao-huang

Helmify has some limitations. I have created an issue, but it has not received any answer yet.

Helmify has some limitations. I have created an issue, but it has not received any answer yet.

I'm not sure if I understand you correctly, but metadata.name is correct for CRDs in my generated helm chart. Actually, I cannot find any trace of RELEASE_NAME string in the generated directory. Am I missing something?

I've compared the virtink plain manifest with the templated manifest generated by helmify, and it looks okay. However, helmify adds the name of the release to all 'metadata.name' fields. For example, "virtink-controller" becomes "test-release-virtinkink-controller". If this is acceptable for virtink, it can be used.

I've compared the virtink plain manifest with the templated manifest generated by helmify, and it looks okay. However, helmify adds the name of the release to all 'metadata.name' fields. For example, "virtink-controller" becomes "test-release-virtinkink-controller". If this is acceptable for virtink, it can be used.

I believe that's acceptable. I'll put some tests on the generated chart. If all goes well, I shall make it available to public

I've published a helm chart at https://github.com/smartxworks/virtink-charts , PRs welcome. I'm closing this issue, feel free to reopen if necessary