Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing fix for PHP 8.4 on StringEval::populate() #1087

Open
ykawasaki683 opened this issue Nov 29, 2024 · 0 comments
Open

missing fix for PHP 8.4 on StringEval::populate() #1087

ykawasaki683 opened this issue Nov 29, 2024 · 0 comments

Comments

@ykawasaki683
Copy link

I found this error blow.

PHP Deprecated:  Smarty\Resource\StringEval::populate(): Implicitly marking parameter $_template as nullable is deprecated, the explicit nullable type must be used instead in /var/www/ec2/front/vendor/smarty/smarty/src/Resource/StringEval.php on line 34

This error disappeared by fixing this line like below.

public function populate(\Smarty\Template\Source $source, \Smarty\Template $_template = null)

public function populate(\Smarty\Template\Source $source, ?\Smarty\Template $_template = null)

On this fix, I referred this PR.
#1043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants