Skip to content
This repository was archived by the owner on Nov 8, 2017. It is now read-only.

Function.extractParams is deprecated. #262

Open
coolamit1240 opened this issue Mar 7, 2017 · 23 comments
Open

Function.extractParams is deprecated. #262

coolamit1240 opened this issue Mar 7, 2017 · 23 comments

Comments

@coolamit1240
Copy link

Assigning custom properties to a marker when creating/copying it is
deprecated. Please, consider storing the custom properties you need in
some other object in your package, keyed by the marker's id property.

Function.extractParams (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/opt/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/opt/atom/resources/app.asar/src/text-editor.js:1753:38)
ConflictVisitor.markSide (/home/amit/.atom/packages/merge-conflicts/lib/conflict.js:308:38)
ConflictVisitor.visitTheirSide (/home/amit/.atom/packages/merge-conflicts/lib/conflict.js:301:29)
@bhushangahire
Copy link

+1

@ItamarGronich
Copy link

Me two +1

@danfoley
Copy link

+1

10 similar comments
@jasondibenedetto
Copy link

+1

@amoghesturi
Copy link

+1

@fh250250
Copy link

+1

@g0ody
Copy link

g0ody commented Mar 20, 2017

+1

@jurmarcus
Copy link

+1

@deemco
Copy link

deemco commented Mar 23, 2017

+1

@patrickml
Copy link

+1

@ibcWillJust42
Copy link

+1

@Andor-Z
Copy link

Andor-Z commented Mar 26, 2017

+1

@criswilk
Copy link

+1

dbachko added a commit to dbachko/merge-conflicts that referenced this issue Mar 29, 2017
@erasmus
Copy link

erasmus commented Apr 3, 2017

+1

smashwilson added a commit that referenced this issue Apr 3, 2017
Fixes deprecation call to assign custom properties to a marker #262
@timfallmk
Copy link

+1

5 similar comments
@enygmatik
Copy link

+1

@HermanBergner
Copy link

+1

@Nrohtgnohp
Copy link

+1

@shillem
Copy link

shillem commented May 8, 2017

+1

@iknowmac
Copy link

iknowmac commented May 9, 2017

+1

@pichouk
Copy link

pichouk commented May 9, 2017

Instead of just adding "+1" (did you know you can just thumbsup the first message ?) until the end of time, does anyone understand the issue/have an idea of how to fix this ?

@timfallmk
Copy link

@pichouk I think the suggested solution was in the first message of this issue. I just don't see any movement on this repo.

@smashwilson
Copy link
Owner

This was actually fixed in #265, I just, uh, never actually did the release. 😅 I just pushed 1.4.5 with that PR merged, but completely untested because, as some of you have noticed:

I just don't see any movement on this repo.

✨ This repository is being deprecated

The full announcement is there, but the short version is that there's a better core package now that eclipses the functionality in this one 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests