diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java index ef99b93c573..baa2003d7dd 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java @@ -36,7 +36,6 @@ import org.apache.hadoop.ozone.om.helpers.OmKeyInfo; import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; import org.apache.hadoop.ozone.om.helpers.RepeatedOmKeyInfo; -import org.apache.hadoop.ozone.om.helpers.WithMetadata; import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerDoubleBufferHelper; import org.apache.hadoop.ozone.om.request.util.OmResponseUtil; import org.apache.hadoop.ozone.om.request.validation.RequestFeatureValidator; @@ -221,18 +220,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, throw new OMException("Failed to " + action + " key, as " + dbOpenKey + "entry is not found in the OpenKey table", KEY_NOT_FOUND); } - boolean isPreviousCommitHsync = false; if (isHSync) { omKeyInfo.getMetadata().put(OzoneConsts.HSYNC_CLIENT_ID, String.valueOf(commitKeyRequest.getClientID())); - } else { - final String clientIdString - = String.valueOf(commitKeyRequest.getClientID()); - isPreviousCommitHsync = java.util.Optional.ofNullable(omKeyInfo) - .map(WithMetadata::getMetadata) - .map(meta -> meta.get(OzoneConsts.HSYNC_CLIENT_ID)) - .filter(id -> id.equals(clientIdString)) - .isPresent(); } omKeyInfo.setDataSize(commitKeyArgs.getDataSize()); omKeyInfo.setModificationTime(commitKeyArgs.getModificationTime()); @@ -247,7 +237,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, long correctedSpace = omKeyInfo.getReplicatedSize(); // if keyToDelete isn't null, usedNamespace needn't check and // increase. - if (keyToDelete != null && (isHSync || isPreviousCommitHsync)) { + if (keyToDelete != null && isHSync) { correctedSpace -= keyToDelete.getReplicatedSize(); checkBucketQuotaInBytes(omMetadataManager, omBucketInfo, correctedSpace); diff --git a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java index 30d207b5d28..2f22f305232 100644 --- a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java +++ b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java @@ -34,7 +34,6 @@ import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; import org.apache.hadoop.ozone.om.helpers.OzoneFSUtils; import org.apache.hadoop.ozone.om.helpers.RepeatedOmKeyInfo; -import org.apache.hadoop.ozone.om.helpers.WithMetadata; import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerDoubleBufferHelper; import org.apache.hadoop.ozone.om.request.file.OMFileRequest; import org.apache.hadoop.ozone.om.request.util.OmResponseUtil; @@ -162,18 +161,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, dbOpenFileKey + "entry is not found in the OpenKey table", KEY_NOT_FOUND); } - boolean isPreviousCommitHsync = false; if (isHSync) { omKeyInfo.getMetadata().put(OzoneConsts.HSYNC_CLIENT_ID, String.valueOf(commitKeyRequest.getClientID())); - } else { - final String clientIdString - = String.valueOf(commitKeyRequest.getClientID()); - isPreviousCommitHsync = java.util.Optional.ofNullable(omKeyInfo) - .map(WithMetadata::getMetadata) - .map(meta -> meta.get(OzoneConsts.HSYNC_CLIENT_ID)) - .filter(id -> id.equals(clientIdString)) - .isPresent(); } omKeyInfo.setDataSize(commitKeyArgs.getDataSize()); @@ -198,7 +188,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager, // if keyToDelete isn't null, usedNamespace shouldn't check and // increase. - if (keyToDelete != null && (isHSync || isPreviousCommitHsync)) { + if (keyToDelete != null && isHSync) { correctedSpace -= keyToDelete.getReplicatedSize(); checkBucketQuotaInBytes(omMetadataManager, omBucketInfo, correctedSpace);