Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serde does not compile on constrained blobs #3890

Open
rcoh opened this issue Oct 23, 2024 · 1 comment
Open

serde does not compile on constrained blobs #3890

rcoh opened this issue Oct 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rcoh
Copy link
Collaborator

rcoh commented Oct 23, 2024

Example failing shape:

union ResourcesContent {
 // Max 6Mb
 @length(max: 6291456)
 textFile: Blob
}
@david-perez david-perez added the bug Something isn't working label Oct 23, 2024
@rcoh
Copy link
Collaborator Author

rcoh commented Oct 25, 2024

This bug happens if there are no unconstrained blobs in the model.

@rcoh rcoh mentioned this issue Oct 25, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 23, 2024
@rcoh
Fix serde on constrained blobs (#3893)
66b2311 
## Motivation and Context
#3890 

## Description
Replace the computed type (which will be a constrained shape, not what
we want!) with an absolute type.

## Testing
- [x] New unit test that fails without this fix applied.

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] For changes to the smithy-rs codegen or runtime crates, I have
created a changelog entry Markdown file in the `.changelog` directory,
specifying "client," "server," or both in the `applies_to` key.


----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcoh @david-perez