Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better:docs/developer-guide/contributing/pull-requests #49

Open
DavidDong93 opened this issue Feb 7, 2016 · 8 comments
Open

Better:docs/developer-guide/contributing/pull-requests #49

DavidDong93 opened this issue Feb 7, 2016 · 8 comments

Comments

@DavidDong93
Copy link

[docs/developer-guide/contributing/pull-requests]
That decreases the likelihood that your code is going ***to get included* in a timely manner
它会降低你的代码及时地被收纳的可能性

@DavidDong93
Copy link
Author

You can create a new issue or just indicate you're working on an existing issue
你可以新建一个议题(issue)或者表明你正在对一个现存的议题进行工作

@DavidDong93
Copy link
Author

You should do all of your development for the issue in this branch
在这个分支中,你应该做你关于该议题的全部的开发工作

@DavidDong93
Copy link
Author

The commit message is** properly formatted**
提交的信息格式恰当

@DavidDong93
Copy link
Author

Only one commit is allowed per pull request
每个合并请求(pull request)只能包含一个提交

@DavidDong93
Copy link
Author

Go to your ESLint fork and then** follow the GitHub documentation on how to send a pull request**
到你fork的 ESLint, 按照GitHub 文档 中关于如何发出一个合并请求(pull request)的说明去做

@DavidDong93
Copy link
Author

Monitor the status of the Travis CI build for your pull request
监控Travis CI针对你的合并请求(pull request)所构建的状态

@DavidDong93
Copy link
Author

If it fails, please investigate why. We cannot merge pull requests that fail Travis for any reason.
如果它未能构建状态,请查明原因。我们不能合并那些因任何原因使Travis 未能构建状态的合并请求

@DavidDong93
Copy link
Author

This snippets** adds** all your new changes, then amends the previous commit with them
这段代码会增加你所有的新的变化,然后会修改之前的提交

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant