Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for DNS length limits #26

Open
smola opened this issue Jan 10, 2014 · 3 comments
Open

Check for DNS length limits #26

smola opened this issue Jan 10, 2014 · 3 comments
Assignees
@smola
Labels
enhancement
Milestone
0.3.0

Comments

@smola
Copy link
Owner

smola commented Jan 10, 2014

DNS imposes a 63-byte length on each label, maximum 127 labels, and 253 characters. We should check for these limits

This is where empty labels (excep the root label) should throw an error.
@ghost ghost assigned smola Jan 10, 2014
@smola
Copy link
Owner Author

smola commented Jan 14, 2014

This is also pending of resolution at WHATWG: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24289

@smola smola closed this as completed in 8f45dcd Mar 13, 2014
@smola
Copy link
Owner Author

smola commented Mar 13, 2014

The 63-byte length limit is included in WHATWG as part of the standard IDN ToASCII. Other limits will not be part of the URL spec. I have implemented them in galimatias anyway. I'll provide an option to disable these checks if there is a use case for it.

@smola
Copy link
Owner Author

smola commented Oct 28, 2014

We lost DNS checks when upgrading IDNA:
5ce2cb9

@smola smola reopened this Oct 28, 2014
@smola smola added this to the 0.3.0 milestone Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smola smola

Labels
enhancement
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@smola