Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use managed versions of Maven plugins #60

Open
dkager opened this issue Nov 5, 2015 · 4 comments
Open

Use managed versions of Maven plugins #60

dkager opened this issue Nov 5, 2015 · 4 comments

Comments

@dkager
Copy link

dkager commented Nov 5, 2015

Eclipse gives me a lot of these warnings:

Description Resource    Path    Location    Type
Duplicating managed version 1.7.2 for slf4j-jdk14   pom.xml /dotify-formatter   line 119    Maven pom Loading Problem

This is not an issue of course, one can ignore this warning. But it brings up the question if we need specific versions of plugins that are either the same as what it found anyway, or that are older without a comment describing why the newer version doesn't work. Can we rely on the 'managed' aspect and let the build system figure it out, e.g. as I've done in the ascii_table branch? The fewer things to keep track of, the better.

@bertfrees
Copy link
Member

This particular case (slf4j-jdk14) isn't a plugin but a test dependency. But anyway, regardless of what type of dependency but especially for build-time dependencies (which includes plugins and test dependencies), it is important that they are unambiguously defined in order to have deterministic builds. Sometimes it is possible to remove some version declarations because a parent already defines it and that inherited version is fine (what you did in 4833336 for example). But sometimes a version needs to be overridden because the managed version is wrong. slf4j-jdk14 is an example of that I believe.

@bertfrees
Copy link
Member

Describing why the managed version is wrong is indeed a good idea. In this slf4j-jdk14 case I think I didn't know why the managed version didn't work.

@dkager
Copy link
Author

dkager commented Nov 5, 2015

I haven’t had any issues thus far (which doesn’t say much), but please add stuff back that shouldn’t have been removed. I’m taking the dumb approach of trusting my IDE, so this will definitely not strip every version declaration.

@bertfrees
Copy link
Member

  • To do: explain all version declarations in module POMs (such as slf4j-jdk14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants