Feature/94 mail ui #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cancel button doesn't work |
Right, doesn't work for me either (Windows x64). Please fix that. There are also many lines of code that are commented out or are debugging output. Please remove them. |
julisa99
reviewed
Aug 28, 2019
| @@ -70,6 +71,17 @@ MainWindow::MainWindow(QWidget *parent, bool useCam, QString outputPath, | |||
| this->showDia(); | |||
|
|
|||
| initializeSidebar(); | |||
|
|
|||
| QObject::connect(&m_mailDialog, &MailDialog::enteredMail, [=](QString text){ | |||
| std::cout << "sdfsdf\n"; | |||
julisa99
reviewed
Aug 28, 2019
| } | ||
| // bool ok; | ||
| m_mailDialog.exec(); | ||
| // QString text = QInputDialog::getText(this, tr("Schneckenpost"), |
There was a problem hiding this comment.
Why is that commented out and not removed?
julisa99
reviewed
Aug 28, 2019
| }); | ||
| QObject::connect(&m_buttonOk, &QPushButton::clicked, [=](){ | ||
| this->done(1); | ||
| }); |
There was a problem hiding this comment.
To close the dialog, please add
QObject::connect(&m_buttonCancel, &QPushButton::clicked, this, [=]() { this->close(); });
julisa99
reviewed
Aug 28, 2019
julisa99
reviewed
Aug 28, 2019
| , m_layout() { | ||
|
|
||
| QObject::connect(&m_buttonOk, &QPushButton::clicked, [=](){ | ||
| emit enteredMail(this->m_input.text()); |
There was a problem hiding this comment.
For user experience: First close the mail window and then send the mail?
QObject::connect(&m_buttonOk, &QPushButton::clicked, [=](){ this->close(); emit enteredMail(this->m_input.text()); });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #94