README update and sync-*.yml "fix" #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like line26 was the issue - perhaps the indentation.
- release-to-candidate.yml --> was *yaml
kz6fittycent
force-pushed
the
candidate
branch
from
6b39e12 to
36e68c5
Compare
- MIT - kz6fittycent and Merlijn Sebrechts
kz6fittycent
force-pushed
the
candidate
branch
from
36e68c5 to
01ed8d6
Compare
|
If there are anymore contributors to the snap that we want to list, please provide that list of names here and I'll add them with another commit. TY. |
merlijn-sebrechts
requested changes
Dec 12, 2023
There was a problem hiding this comment.
In addition to the comments above: You should add a blank line after every heading. Example:
## License
The license of both the build files in this repository and Jenkins itself is the [MIT License](https://github.com/jenkinsci/jenkins/blob/master/LICENSE.txt)Per Merlijn's comments.
kz6fittycent
force-pushed
the
candidate
branch
from
966a979 to
545c7a4
Compare
|
I've addressed those various issues. Thanks for catching them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signal-desktopsync-version-with-upstream.yml- seems to be an indent causing an issue, as the script is working locally