Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query to filter flagged proposals #624

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Query to filter flagged proposals #624

merged 3 commits into from
Aug 1, 2023

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Jul 29, 2023 •
edited
Loading

How to test:

  • To return all proposals:

    {
  proposals(first:1000){
    id
    space {
      id
    }
    flagged
  }
}

  • To return only flagged proposals:

    {
  proposals(first:1000, where:{flagged:true}){
    id
    space {
      id
    }
    flagged
  }
}

  • To return only nonflagged proposals:

    {
  proposals(first:1000, where:{flagged:false}){
    id
    space {
      id
    }
    flagged
  }
}

@codecov
Copy link

codecov bot commented Jul 29, 2023 •
edited
Loading

Codecov Report

Merging #624 (6d4ede3) into master (4c5609c) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master    #624   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          38      38           
  Lines        1652    1662   +10     
  Branches       38      38           
======================================
- Misses       1614    1624   +10     
  Partials       38      38
Files Changed Coverage Δ
src/graphql/operations/proposals.ts 0.00% <0.00%> (ø)

samuveth
samuveth approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@samuveth samuveth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@samuveth samuveth merged commit cdc2c9f into master Aug 1, 2023
4 checks passed
@samuveth samuveth deleted the query-to-ignore-flagged-proposals branch August 1, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack left review comments

@samuveth samuveth samuveth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaituVR @bonustrack @samuveth