Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network to delegation portal #916

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Aug 28, 2024

Toward https://github.com/snapshot-labs/workflow/issues/177

This PR will return the new delegationNetwork property in the Delegation Portal setting.

When the property does not exist (for old data), it will always return 1 (ethereum).

Test

This space does not have delegationNetwork set, and the hub will return 1

query Spaces {
  spaces (where: { id: "test.wa0x6e.eth"}  ){
    id
    delegationPortal {
      delegationApi
      delegationType
      delegationNetwork
      delegationContract
    }
  }
}

@wa0x6e wa0x6e changed the title Feat-add-delegation-portal-network feat: add network to delegation portal Aug 28, 2024
@wa0x6e wa0x6e requested a review from ChaituVR August 28, 2024 05:01
@wa0x6e wa0x6e marked this pull request as ready for review August 28, 2024 05:01
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 9772b4c into master Aug 28, 2024
2 checks passed
@ChaituVR ChaituVR deleted the feat-add-delegation-portal-network branch August 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants