-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show hints on proposal editor to get verified or to get turbo #773
Conversation
|
…into feat-show-turbo-hints
Text and the left fire icon do not seem to be aligned |
}; | ||
|
||
export const MAX_CHOICES = { | ||
default: 500, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change default to be 10 for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? to test?
try running this in the console
for (let i = 0; i < 500; i++) {
document.querySelector(".static .s-base.mb-5 button.rounded-full.border.button.text-skin-link.bg-skin-bg.w-full.flex.items-center.justify-center.space-x-1").click();
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the few UI issues raised above, everything's working well for me
Daily proposal limit on unverified spaces should be on another PR I think, since not related to turbo
There's also the issue about choices count above limit not showing any error message, but not related to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
We're currently showing this hint for onchain spaces, when proposal body is too long (> 10K). Do not make sense since turbo is not supported yet for onchain spaces |
Continued in #803 |
Test only after merging snapshot-labs/snapshot-hub#925 and snapshot-labs/snapshot-hub#926
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/134
How to test
for example:
When body chars limit is reached:
When proposals limit is reached:
When choices limit is reached: