-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
=> Bluesky: link preview embeds sometimes fail or contain raw HTML #1615
Comments
More examples with |
Apologies for the question. I note that this has been labeled as a bug. I’m not sure of the significance of that distinction. The lack of an image preview on posts bridged from Flipboard is making those posts look poor and very dull or uninteresting. Quite bot like too. Whats the outlook on overcoming this? |
@Steviemac1 hmm, I'm seeing lots of link previews on Flipboard posts, eg https://bsky.app/profile/ScienceDesk.flipboard.social.ap.brid.gy . They should generally be there if the post wasn't truncated. Feel free to send an example where the post wasn't truncated and the preview was missing, I'm happy to look. |
This Bluesky account is fed by bridged posts from Flipboard. @Ayethatllbright.flipboard.com.ap.brid.gy |
Thanks! Looks like a few of the most common sites that that feed links to are hitting this bug, including audiophix.com, netflixlife.com, and singersroom.com. Sorry for the trouble! Fwiw I do see a few successful link previews in that feed from other sites, eg abc.net.au, ultimateclassicrock.com, and loudersound.com. |
I hasn't spotted that some sites were ok and others weren't.Having said that, if you go back by 23days+ on the posts on that account, those failing now were much more consistently ok. AudioPhix.com as one example had plenty of previews at that point. I’m not sure what changed or where at that stage around Dec. 18 though. Nor whether that's in the bridging process, at Flipboard or on those sites. |
There’s a slight change that may or may not be significant. The bridged posts from Flipboard that have failed to include the image just don't have it or a space for it. Today there’s some sites now where bridged posts via Flioboard are showing a blank gap where an image should be. I reckon that's new, and in one case, it’s a site where images have been appearing properly until now. See example below. https://bsky.app/profile/Ayethatllbright.flipboard.com.ap.brid.gy/post/3lfs2c2skouh2 |
Sigh, yeah, sorry, a recent Bluesky team appview change broke us. Fix is merged, hopefully it'll be deployed soon! bluesky-social/atproto#3370 |
It looks as though that fix above worked although issue 1715 just added may suggest otherwise. It still leaves the basic issue of some bridged items from Flipboard to Bluesky not giving an image preview, as described above. Current examples here. To manage my expectations is that likely to progress to a fix at some point and at what sort of general timescale? I've weeks/ months. Or is it more likely to remain as it is for a much longer period? |
Yes! The original bug here is still open. It's medium priority for us right now, I'd love to get to it, but I don't have an ETA for you, sorry. |
Understood, thanks Ryan, that covers what I needed to know nicely. |
There’s a new variation to the problem of some Images not previewing when posts are bridged to Bluesky. I've just noticed that several bridged posts today are showing an image, but it’s the same image for all posts, not the correct image. They all show the image from the first of my bridged posts today. You can see this on posts 18 Feb on @Ayethatllbright.flipboard.com.ap.brid.gy for the examples. |
Whoa, weird! Thanks for reporting, will look. |
Ah, looks like this is due to snarfed/granary#885 . We started linking unbridged @-mentions like @music-stories-Ayethatllbright in these posts, and we're using that @-mention for the link preview instead of the article link. cc @Daft-Freak, I wonder what we should do here. Ideally we wouldn't generate link previews for @-mentions, but when we generate link previews for Bluesky, those aren't clearly distinguished, they're all link facets: Lines 912 to 926 in 4bd8ebb
We could use whether the link text starts with |
Ah, and tags are processed before links so it'll always be first... I guess we need to track if something was originally a link, though the only idea I have right now is sticking some extra property on the facet for a bit... |
Right now I'm thinking we only consider URLs for previews if they're not in the AS1's |
Damn, looks like that fix ^ didn't work. Example: https://bsky.app/profile/FlipboardBR.flipboard.com.ap.brid.gy |
Oh, this is "fun"... An example from @Ayethatllbright.flipboard.com: We start off with a mention tag with a url of
Then the actual links are parsed from the content... last. Edit: the only remotely helpful thing here is that the first url is a redirect to the second... Edit 2: perhaps just to get back to how things were before, we collect the "fallback" link facets and append them after handling everything else? |
Hah, I've been debugging too, and saw the same thing. And the redirect threw me for a minute too, whee.
Hmm maybe! That would definitely work, but it feels a bit brittle. I'm actually maybe inclined to go with your earlier suggestion, seems a bit more robust...?
|
Goddamn complexity 😆 😢 |
...ah, and I see what you mean, even an extra property on the facet wouldn't help us because neither the name nor the URL directly match the HTML link in content. Sigh. So then, probably either the leading '@' character heuristic, or we have to follow redirects for all mention tag URLs before comparing them here. |
…ed @-mentions for #1615 (comment), cc @Daft-Freak. just uses leading @ character as a heuristic. definitely not ideal, but noticeably simpler than actually doing this "right." 😐
Woo, looks like the |
Thanks for correcting that repeated image on links. The underlying issue of images not appearing remains and I know is on the radar to fix at some point. Just to reflect on that, some of the bridged posts with links used to have an image appear, others didn't. Of the latest bridged posts, I haven't seen any with an image. That could be coincidence or related to the issue/fix for repeated image. Later: And then an hour or two after a couple of posts with images came through… 🤷♂️ |
…ntent convert HTML content/summary to plain text description for snarfed/bridgy-fed#1615
Fixed the raw HTML here. Previews from those sites still aren't great, but they're at least better. https://bsky.app/profile/fedi.test.snarfed.org/post/3liy4734pxhu2 : Realistically, to get these previews better on the long tail of sites with less common markup, I'd need to switch to a third party link preview generator. Maybe someday! |
Ugh. Example: https://bsky.app/profile/pcottle.threads.net.ap.brid.gy/post/3lczzpgrtsep2
From #microformats:
The text was updated successfully, but these errors were encountered: