Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacy v3 support #1701

Closed
yinxiangshi opened this issue Apr 21, 2022 · 11 comments
Closed

Spacy v3 support #1701

yinxiangshi opened this issue Apr 21, 2022 · 11 comments

Comments

@yinxiangshi
Copy link

Just want to re-ask about #1621
I have noticed that snorkel still doesn't support spacy v3. I can help with this, but I think the info probably needs to update.
So right now for snorkel, which files use spacy?

@cmglaze
Copy link

cmglaze commented Apr 21, 2022

Hi @yinxiangshi, the same set of files use spacy as before: #1621 (comment)

@yinxiangshi
Copy link
Author

Oh, thank you.

@rjurney
Copy link

rjurney commented Apr 22, 2022

@henryre is there any way to stop certain tickets from getting cleaned every so often? A valid definition of a feature is open source product management and you’re obfuscating even the ones I’m sure you want.

@yinxiangshi
Copy link
Author

@rjurney Hello, I've added preliminary spacy v3 support in pr. Could you please help review the changes? I am not that sure wrapper still needs changes. Thanks.

@rjurney
Copy link

rjurney commented Apr 22, 2022

@yinxiangshi yes, it so happens I just left my job so I have time and need something to do :) Let me just set up my computer and I’ll get on it!

@yinxiangshi
Copy link
Author

@rjurney In my perspective, I think we just need to add new parameters of _nlp in the preprocessor. I didn't see any other needed changes I think. Plz help me! Thanks!

@rjurney
Copy link

rjurney commented Apr 24, 2022

@yinxiangshi Got my new computer setup, looking now!

@yinxiangshi
Copy link
Author

@rjurney This is what I am looking forward :) Cong about your new life & new computer!

@rjurney
Copy link

rjurney commented Apr 30, 2022

@yinxiangshi the second booster wiped me out like moments after I posted that... here goes again!

@rjurney
Copy link

rjurney commented May 2, 2022

@yinxiangshi I guess we are using #1621 now?

@rjurney
Copy link

rjurney commented May 2, 2022

Sorry for the dupe comment, but:

@yinxiangshi I got tox -e complex to run. I am looking over the relevant files to see if there are anything we missed. I didn't quite get your comments about config - I am not sure how that changes things, unless we want to add spaCy config support to snorkel. I suppose that is reasonable, let me look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants